add comment ID fragment to uniquely refer to comments default tip

Tue, 09 Jun 2026 16:24:15 +0200

author
Mike Becker <universe@uap-core.de>
date
Tue, 09 Jun 2026 16:24:15 +0200
changeset 425
adaf9cf8b97e
parent 424
0343792a6175

add comment ID fragment to uniquely refer to comments

fixes #884

src/main/webapp/WEB-INF/changelogs/changelog-de.jspf file | annotate | diff | comparison | revisions
src/main/webapp/WEB-INF/changelogs/changelog.jspf file | annotate | diff | comparison | revisions
src/main/webapp/WEB-INF/jsp/issue-view.jsp file | annotate | diff | comparison | revisions
src/main/webapp/WEB-INF/jsp/issues-feed.jsp file | annotate | diff | comparison | revisions
--- a/src/main/webapp/WEB-INF/changelogs/changelog-de.jspf	Sun May 24 14:29:27 2026 +0200
+++ b/src/main/webapp/WEB-INF/changelogs/changelog-de.jspf	Tue Jun 09 16:24:15 2026 +0200
@@ -27,6 +27,7 @@
 <h3>Version 1.6.2 (Vorschau)</h3>
 
 <ul>
+    <li>RSS Einträge für Kommentare enthalten nun die Kommentar-ID in der GUID.</li>
     <li>Regression bei der Darstellung von Markdown-Überschriften behoben.</li>
 </ul>
 
--- a/src/main/webapp/WEB-INF/changelogs/changelog.jspf	Sun May 24 14:29:27 2026 +0200
+++ b/src/main/webapp/WEB-INF/changelogs/changelog.jspf	Tue Jun 09 16:24:15 2026 +0200
@@ -27,6 +27,7 @@
 <h3>Version 1.6.2 (preview)</h3>
 
 <ul>
+    <li>Add the comment ID to the GUID of RSS entries for comments.</li>
     <li>Fix regression with rendering Markdown headings.</li>
 </ul>
 
--- a/src/main/webapp/WEB-INF/jsp/issue-view.jsp	Sun May 24 14:29:27 2026 +0200
+++ b/src/main/webapp/WEB-INF/jsp/issue-view.jsp	Tue Jun 09 16:24:15 2026 +0200
@@ -357,7 +357,7 @@
     </table>
 </form>
 <c:forEach var="comment" items="${viewmodel.comments}">
-    <div class="comment">
+    <div class="comment" id="comment-${comment.id}">
         <div class="comment-author">
             <c:if test="${not empty comment.author}">
                 <c:if test="${not empty comment.author.mail}">
--- a/src/main/webapp/WEB-INF/jsp/issues-feed.jsp	Sun May 24 14:29:27 2026 +0200
+++ b/src/main/webapp/WEB-INF/jsp/issues-feed.jsp	Tue Jun 09 16:24:15 2026 +0200
@@ -49,6 +49,7 @@
                 <c:when test="${not empty entry.issue}">
                     <c:set var="issue" value="${entry.issue}"/>
                     <c:set var="link" value="${issueHref}${issue.id}"/>
+                    <c:set var="fragment" value=""/>
                     <title>[<fmt:message key="feed.issues.type.${entry.type}"/>] #${issue.id} - <c:if test="${empty viewmodel.project}"><c:out value="${issue.project}" /> - </c:if><c:out value="${issue.currentSubject}"/></title>
                     <description><![CDATA[
                         <h1>#${issue.id} - ${issue.subject}</h1>
@@ -70,6 +71,7 @@
                 <c:when test="${not empty entry.comment}">
                     <c:set var="comment" value="${entry.comment}"/>
                     <c:set var="link" value="${issueHref}${comment.issueid}"/>
+                    <c:set var="fragment" value="#comment-${comment.id}"/>
                     <title>[<fmt:message key="feed.issues.type.${entry.type}"/>] #${comment.issueid} - <c:if test="${empty viewmodel.project}"><c:out value="${comment.project}" /> - </c:if><c:out value="${comment.currentSubject}"/></title>
                     <description><![CDATA[
                         <div style="white-space: pre-wrap;">${comment.comment}</div>
@@ -77,8 +79,8 @@
                     <category><fmt:message key="feed.issues.type.${entry.type}"/></category>
                 </c:when>
             </c:choose>
-            <link>${link}?source=rss</link>
-            <guid isPermaLink="true">${link}</guid>
+            <link>${link}?source=rss${fragment}</link>
+            <guid isPermaLink="true">${link}${fragment}</guid>
             <pubDate><fmt:formatDate value="${entry.time}" pattern="EEE, dd MMM yyyy HH:mm:ss zzz"/></pubDate>
             <c:if test="${not empty entry.author}">
             <author><c:out value="${entry.author.displayname}"/> </author>

mercurial