fixes #726 - quick resolve not writing history entry default tip

Mon, 15 Sep 2025 20:13:22 +0200

author
Mike Becker <universe@uap-core.de>
date
Mon, 15 Sep 2025 20:13:22 +0200
changeset 390
b2f8cce6a160
parent 389
9d7f34e06d8d

fixes #726 - quick resolve not writing history entry

no changelog entry because the feature is being introduced with this version

src/main/kotlin/de/uapcore/lightpit/logic/IssueLogic.kt file | annotate | diff | comparison | revisions
src/main/kotlin/de/uapcore/lightpit/servlet/IssuesServlet.kt file | annotate | diff | comparison | revisions
src/main/kotlin/de/uapcore/lightpit/servlet/ProjectServlet.kt file | annotate | diff | comparison | revisions
--- a/src/main/kotlin/de/uapcore/lightpit/logic/IssueLogic.kt	Sun Sep 14 16:45:05 2025 +0200
+++ b/src/main/kotlin/de/uapcore/lightpit/logic/IssueLogic.kt	Mon Sep 15 20:13:22 2025 +0200
@@ -136,7 +136,7 @@
     return true
 }
 
-fun issueQuickResolve(dao: DataAccessObject, issue: Issue) {
+fun issueQuickResolve(http: HttpRequest, dao: DataAccessObject, issue: Issue) {
     if (issue.status.phase == IssueStatusPhase.Done) return
     if (issue.isTrackingVariantStatus) {
         issue.variantStatus.filter { it.value.phase != IssueStatusPhase.Done }.keys.forEach {
@@ -147,6 +147,7 @@
     }
     issue.updateStatusFromVariants()
     dao.updateIssue(issue)
+    dao.insertHistoryEvent(http.user, issue)
 }
 
 fun renderIssueView(
--- a/src/main/kotlin/de/uapcore/lightpit/servlet/IssuesServlet.kt	Sun Sep 14 16:45:05 2025 +0200
+++ b/src/main/kotlin/de/uapcore/lightpit/servlet/IssuesServlet.kt	Mon Sep 15 20:13:22 2025 +0200
@@ -61,7 +61,7 @@
             http.response.sendError(404)
             return
         }
-        issueQuickResolve(dao, issue)
+        issueQuickResolve(http, dao, issue)
         http.renderCommit("${pathInfos.issuesHref}${issue.id}")
     }
 
--- a/src/main/kotlin/de/uapcore/lightpit/servlet/ProjectServlet.kt	Sun Sep 14 16:45:05 2025 +0200
+++ b/src/main/kotlin/de/uapcore/lightpit/servlet/ProjectServlet.kt	Mon Sep 15 20:13:22 2025 +0200
@@ -398,7 +398,7 @@
             http.response.sendError(404)
             return
         }
-        issueQuickResolve(dao, issue)
+        issueQuickResolve(http, dao, issue)
         withPathInfo(http, dao)?.let { path ->
             http.renderCommit("${path.issuesHref}${issue.id}")
         }

mercurial