Sat, 31 Oct 2020 09:56:00 +0100
fixes issue sorter not recognizing issues as "equal" if their ETAs are both null
/* * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER. * * Copyright 2018 Mike Becker. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGE. * */ package de.uapcore.lightpit.dao.postgres; import de.uapcore.lightpit.dao.Functions; import de.uapcore.lightpit.dao.VersionDao; import de.uapcore.lightpit.entities.Project; import de.uapcore.lightpit.entities.Version; import de.uapcore.lightpit.entities.VersionStatus; import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; import java.util.List; public final class PGVersionDao implements VersionDao { private final PreparedStatement insert, update, list, find, findByNode; public PGVersionDao(Connection connection) throws SQLException { final var query = "select versionid, project, name, node, ordinal, status from lpit_version"; list = connection.prepareStatement(query + " where project = ? " + "order by ordinal desc, lower(name) desc"); find = connection.prepareStatement(query + " where versionid = ?"); findByNode = connection.prepareStatement(query + " where project = ? and node = ?"); insert = connection.prepareStatement( "insert into lpit_version (name, node, ordinal, status, project) values (?, ?, ?, ?::version_status, ?)" ); update = connection.prepareStatement( "update lpit_version set name = ?, node = ?, ordinal = ?, status = ?::version_status where versionid = ?" ); } private static Version mapColumns(ResultSet result) throws SQLException { final var version = new Version(result.getInt("versionid")); version.setName(result.getString("name")); version.setNode(result.getString("node")); version.setOrdinal(result.getInt("ordinal")); version.setStatus(VersionStatus.valueOf(result.getString("status"))); return version; } private static int setFields(PreparedStatement stmt, Version instance) throws SQLException { int column = 0; stmt.setString(++column, instance.getName()); stmt.setString(++column, instance.getNode()); stmt.setInt(++column, instance.getOrdinal()); stmt.setString(++column, instance.getStatus().name()); return column; } @Override public void save(Version instance, Project project) throws SQLException { int column = setFields(insert, instance); insert.setInt(++column, project.getId()); insert.executeUpdate(); } @Override public boolean update(Version instance) throws SQLException { if (instance.getId() < 0) return false; int column = setFields(update, instance); update.setInt(++column, instance.getId()); return update.executeUpdate() > 0; } @Override public List<Version> list(Project project) throws SQLException { list.setInt(1, project.getId()); return Functions.list(list, PGVersionDao::mapColumns); } @Override public Version find(int id) throws SQLException { find.setInt(1, id); return Functions.find(find, PGVersionDao::mapColumns); } @Override public Version findByNode(Project project, String node) throws SQLException { findByNode.setInt(1, project.getId()); findByNode.setString(2, node);; return Functions.find(findByNode, PGVersionDao::mapColumns); } }