Sun, 28 Jul 2024 13:09:32 +0200
add new save button to issue editor - fixes #398
184 | 1 | /* |
2 | * Copyright 2021 Mike Becker. All rights reserved. | |
3 | * | |
4 | * Redistribution and use in source and binary forms, with or without | |
5 | * modification, are permitted provided that the following conditions are met: | |
6 | * | |
7 | * 1. Redistributions of source code must retain the above copyright | |
8 | * notice, this list of conditions and the following disclaimer. | |
9 | * | |
10 | * 2. Redistributions in binary form must reproduce the above copyright | |
11 | * notice, this list of conditions and the following disclaimer in the | |
12 | * documentation and/or other materials provided with the distribution. | |
13 | * | |
14 | * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | |
15 | * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | |
16 | * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | |
17 | * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | |
18 | * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | |
19 | * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | |
20 | * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | |
21 | * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | |
22 | * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | |
23 | * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |
24 | */ | |
25 | ||
26 | package de.uapcore.lightpit.viewmodel | |
27 | ||
28 | import com.vladsch.flexmark.ext.gfm.strikethrough.StrikethroughExtension | |
29 | import com.vladsch.flexmark.ext.tables.TablesExtension | |
30 | import com.vladsch.flexmark.html.HtmlRenderer | |
31 | import com.vladsch.flexmark.parser.Parser | |
32 | import com.vladsch.flexmark.util.data.MutableDataSet | |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
33 | import com.vladsch.flexmark.util.data.SharedDataKeys |
268 | 34 | import de.uapcore.lightpit.HttpRequest |
184 | 35 | import de.uapcore.lightpit.entities.* |
263
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
36 | import de.uapcore.lightpit.types.* |
184 | 37 | import kotlin.math.roundToInt |
38 | ||
249
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
39 | class IssueSorter(private vararg val criteria: Criteria) : Comparator<Issue> { |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
40 | enum class Field { |
271 | 41 | DONE, PHASE, STATUS, CATEGORY, ETA, UPDATED, CREATED; |
42 | ||
43 | val resourceKey: String by lazy { | |
44 | if (this == DONE) "issue.filter.sort.done" | |
45 | else if (this == PHASE) "issue.filter.sort.phase" | |
46 | else "issue.${this.name.lowercase()}" | |
47 | } | |
249
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
48 | } |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
49 | |
271 | 50 | data class Criteria(val field: Field, val asc: Boolean = true) { |
51 | override fun toString(): String { | |
52 | return "$field.$asc" | |
53 | } | |
54 | } | |
249
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
55 | |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
56 | override fun compare(left: Issue, right: Issue): Int { |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
57 | if (left == right) { |
260 | 58 | return 0 |
249
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
59 | } |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
60 | for (c in criteria) { |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
61 | val result = when (c.field) { |
267
d8ec2d8ffa82
fix default sort criteria
Mike Becker <universe@uap-core.de>
parents:
265
diff
changeset
|
62 | Field.PHASE -> left.status.phase.compareTo(right.status.phase) |
d8ec2d8ffa82
fix default sort criteria
Mike Becker <universe@uap-core.de>
parents:
265
diff
changeset
|
63 | Field.DONE -> (left.status.phase == IssueStatusPhase.Done).compareTo(right.status.phase == IssueStatusPhase.Done) |
265
6a21bb926e02
add more possible sort criteria
Mike Becker <universe@uap-core.de>
parents:
263
diff
changeset
|
64 | Field.STATUS -> left.status.compareTo(right.status) |
6a21bb926e02
add more possible sort criteria
Mike Becker <universe@uap-core.de>
parents:
263
diff
changeset
|
65 | Field.CATEGORY -> left.category.compareTo(right.category) |
6a21bb926e02
add more possible sort criteria
Mike Becker <universe@uap-core.de>
parents:
263
diff
changeset
|
66 | Field.ETA -> left.compareEtaTo(right.eta) |
249
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
67 | Field.UPDATED -> left.updated.compareTo(right.updated) |
265
6a21bb926e02
add more possible sort criteria
Mike Becker <universe@uap-core.de>
parents:
263
diff
changeset
|
68 | Field.CREATED -> left.created.compareTo(right.created) |
249
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
69 | } |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
70 | if (result != 0) { |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
71 | return if (c.asc) result else -result |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
72 | } |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
73 | } |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
74 | return 0 |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
75 | } |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
76 | } |
6bded7090719
move IssueSorter to viewmodel package
Mike Becker <universe@uap-core.de>
parents:
234
diff
changeset
|
77 | |
184 | 78 | class IssueSummary { |
79 | var open = 0 | |
80 | var active = 0 | |
81 | var done = 0 | |
82 | ||
83 | val total get() = open + active + done | |
84 | ||
85 | val openPercent get() = 100 - activePercent - donePercent | |
86 | val activePercent get() = if (total > 0) (100f * active / total).roundToInt() else 0 | |
87 | val donePercent get() = if (total > 0) (100f * done / total).roundToInt() else 100 | |
88 | ||
89 | /** | |
90 | * Adds the specified issue to the summary by incrementing the respective counter. | |
91 | * @param issue the issue | |
92 | */ | |
93 | fun add(issue: Issue) { | |
94 | when (issue.status.phase) { | |
95 | IssueStatusPhase.Open -> open++ | |
96 | IssueStatusPhase.WorkInProgress -> active++ | |
97 | IssueStatusPhase.Done -> done++ | |
98 | } | |
99 | } | |
100 | } | |
101 | ||
284
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
102 | data class CommitLink(val url: String, val hash: String, val message: String) |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
103 | |
184 | 104 | class IssueDetailView( |
292
703591e739f4
add possibility to show issues w/o version or component - fixes #335
Mike Becker <universe@uap-core.de>
parents:
291
diff
changeset
|
105 | val pathInfos: PathInfos, |
184 | 106 | val issue: Issue, |
107 | val comments: List<IssueComment>, | |
108 | val project: Project, | |
263
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
109 | projectIssues: List<Issue>, |
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
110 | val currentRelations: List<IssueRelation>, |
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
111 | /** |
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
112 | * Optional resource key to an error message for the relation editor. |
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
113 | */ |
284
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
114 | val relationError: String?, |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
115 | commitRefs: List<CommitRef> |
184 | 116 | ) : View() { |
291
bcf05cccac6f
replace Enum.values() with Enum.entries
Mike Becker <universe@uap-core.de>
parents:
284
diff
changeset
|
117 | val relationTypes = RelationType.entries |
263
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
118 | val linkableIssues = projectIssues.filterNot { it.id == issue.id } |
284
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
119 | val commitLinks: List<CommitLink> |
263
aa22103809cd
#29 add possibility to relate issues
Mike Becker <universe@uap-core.de>
parents:
260
diff
changeset
|
120 | |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
121 | private val parser: Parser |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
122 | private val renderer: HtmlRenderer |
184 | 123 | |
124 | init { | |
125 | val options = MutableDataSet() | |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
126 | .set(SharedDataKeys.EXTENSIONS, listOf(TablesExtension.create(), StrikethroughExtension.create())) |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
127 | parser = Parser.builder(options).build() |
268 | 128 | renderer = HtmlRenderer.builder( |
129 | options | |
130 | .set(HtmlRenderer.ESCAPE_HTML, true) | |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
131 | ).build() |
184 | 132 | |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
133 | issue.description = formatMarkdown(issue.description ?: "") |
184 | 134 | for (comment in comments) { |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
135 | comment.commentFormatted = formatMarkdown(comment.comment) |
184 | 136 | } |
284
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
137 | |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
138 | val commitBaseUrl = project.repoUrl |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
139 | commitLinks = (if (commitBaseUrl == null || project.vcs == VcsType.None) emptyList() else commitRefs.map { |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
140 | CommitLink(buildCommitUrl(commitBaseUrl, project.vcs, it.hash), it.hash, it.message) |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
141 | }) |
184 | 142 | } |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
143 | |
284
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
144 | private fun buildCommitUrl(baseUrl: String, vcs: VcsType, hash: String): String = |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
145 | with (StringBuilder(baseUrl)) { |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
146 | if (!endsWith("/")) append('/') |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
147 | when (vcs) { |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
148 | VcsType.Mercurial -> append("rev/") |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
149 | else -> append("commit/") |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
150 | } |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
151 | append(hash) |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
152 | toString() |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
153 | } |
671c1c8fbf1c
add full support for commit references - fixes #276
Mike Becker <universe@uap-core.de>
parents:
271
diff
changeset
|
154 | |
234
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
155 | private fun formatEmojis(text: String) = text |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
156 | .replace("(/)", "✅") |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
157 | .replace("(x)", "❌") |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
158 | .replace("(!)", "⚡") |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
159 | |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
160 | private fun formatMarkdown(text: String) = |
d71bc6db42ef
add three emoji sequences (experimental feature)
Mike Becker <universe@uap-core.de>
parents:
231
diff
changeset
|
161 | renderer.render(parser.parse(formatEmojis(text))) |
184 | 162 | } |
163 | ||
164 | class IssueEditView( | |
165 | val issue: Issue, | |
166 | val versions: List<Version>, | |
167 | val components: List<Component>, | |
168 | val users: List<User>, | |
169 | val project: Project, // TODO: allow null values to create issues from the IssuesServlet | |
292
703591e739f4
add possibility to show issues w/o version or component - fixes #335
Mike Becker <universe@uap-core.de>
parents:
291
diff
changeset
|
170 | val pathInfos: PathInfos |
184 | 171 | ) : EditView() { |
172 | ||
173 | val versionsUpcoming: List<Version> | |
174 | val versionsRecent: List<Version> | |
175 | ||
291
bcf05cccac6f
replace Enum.values() with Enum.entries
Mike Becker <universe@uap-core.de>
parents:
284
diff
changeset
|
176 | val issueStatus = IssueStatus.entries |
bcf05cccac6f
replace Enum.values() with Enum.entries
Mike Becker <universe@uap-core.de>
parents:
284
diff
changeset
|
177 | val issueCategory = IssueCategory.entries |
184 | 178 | |
179 | init { | |
180 | val recent = mutableListOf<Version>() | |
231
dcb1d5a7ea3a
#163 removes multi selection for versions
Mike Becker <universe@uap-core.de>
parents:
207
diff
changeset
|
181 | issue.affected?.let { recent.add(it) } |
184 | 182 | val upcoming = mutableListOf<Version>() |
231
dcb1d5a7ea3a
#163 removes multi selection for versions
Mike Becker <universe@uap-core.de>
parents:
207
diff
changeset
|
183 | issue.resolved?.let { upcoming.add(it) } |
dcb1d5a7ea3a
#163 removes multi selection for versions
Mike Becker <universe@uap-core.de>
parents:
207
diff
changeset
|
184 | |
184 | 185 | for (v in versions) { |
186 | if (v.status.isReleased) { | |
187 | if (v.status != VersionStatus.Deprecated) recent.add(v) | |
188 | } else { | |
189 | upcoming.add(v) | |
190 | } | |
191 | } | |
186
05eec764facd
fixes some minor migration regressions
Mike Becker <universe@uap-core.de>
parents:
184
diff
changeset
|
192 | versionsRecent = recent.distinct() |
05eec764facd
fixes some minor migration regressions
Mike Becker <universe@uap-core.de>
parents:
184
diff
changeset
|
193 | versionsUpcoming = upcoming.distinct() |
184 | 194 | } |
195 | } | |
196 | ||
268 | 197 | class IssueFilter(http: HttpRequest) { |
198 | ||
291
bcf05cccac6f
replace Enum.values() with Enum.entries
Mike Becker <universe@uap-core.de>
parents:
284
diff
changeset
|
199 | val issueStatus = IssueStatus.entries |
bcf05cccac6f
replace Enum.values() with Enum.entries
Mike Becker <universe@uap-core.de>
parents:
284
diff
changeset
|
200 | val issueCategory = IssueCategory.entries |
bcf05cccac6f
replace Enum.values() with Enum.entries
Mike Becker <universe@uap-core.de>
parents:
284
diff
changeset
|
201 | val sortCriteria = IssueSorter.Field.entries.flatMap { listOf(IssueSorter.Criteria(it, true), IssueSorter.Criteria(it, false)) } |
268 | 202 | val flagIncludeDone = "f.0" |
203 | val flagMine = "f.1" | |
204 | val flagBlocker = "f.2" | |
205 | ||
206 | val includeDone: Boolean = evalFlag(http, flagIncludeDone) | |
207 | val onlyMine: Boolean = evalFlag(http, flagMine) | |
208 | val onlyBlocker: Boolean = evalFlag(http, flagBlocker) | |
209 | val status: List<IssueStatus> = evalEnum(http, "s") | |
210 | val category: List<IssueCategory> = evalEnum(http, "c") | |
211 | ||
271 | 212 | val sortPrimary: IssueSorter.Criteria = evalSort(http, "primary", IssueSorter.Criteria(IssueSorter.Field.DONE)) |
213 | val sortSecondary: IssueSorter.Criteria = evalSort(http, "secondary", IssueSorter.Criteria(IssueSorter.Field.ETA)) | |
214 | val sortTertiary: IssueSorter.Criteria = evalSort(http, "tertiary", IssueSorter.Criteria(IssueSorter.Field.UPDATED, false)) | |
215 | ||
216 | private fun evalSort(http: HttpRequest, prio: String, defaultValue: IssueSorter.Criteria): IssueSorter.Criteria { | |
217 | val param = http.param("sort_$prio") | |
218 | if (param != null) { | |
219 | http.session.removeAttribute("sort_$prio") | |
220 | val p = param.split(".") | |
221 | if (p.size > 1) { | |
222 | try { | |
223 | http.session.setAttribute("sort_$prio", IssueSorter.Criteria(enumValueOf(p[0]), p[1].toBoolean())) | |
224 | } catch (_:IllegalArgumentException) { | |
225 | // ignore malfored values | |
226 | } | |
227 | } | |
228 | } | |
229 | return http.session.getAttribute("sort_$prio") as IssueSorter.Criteria? ?: defaultValue | |
230 | } | |
231 | ||
268 | 232 | private fun evalFlag(http: HttpRequest, name: String): Boolean { |
233 | val param = http.paramArray("filter") | |
234 | if (param.isNotEmpty()) { | |
235 | if (param.contains(name)) { | |
236 | http.session.setAttribute(name, true) | |
237 | } else { | |
238 | http.session.removeAttribute(name) | |
239 | } | |
240 | } | |
241 | return http.session.getAttribute(name) != null | |
242 | } | |
243 | ||
244 | private inline fun <reified T : Enum<T>> evalEnum(http: HttpRequest, prefix: String): List<T> { | |
245 | val sattr = "f.${prefix}" | |
246 | val param = http.paramArray("filter") | |
247 | if (param.isNotEmpty()) { | |
248 | val list = param.filter { it.startsWith("${prefix}.") } | |
249 | .map { it.substring(prefix.length + 1) } | |
250 | .map { | |
251 | try { | |
252 | // quick and very dirty validation | |
253 | enumValueOf<T>(it) | |
254 | } catch (_: IllegalArgumentException) { | |
255 | // skip | |
256 | } | |
257 | } | |
258 | if (list.isEmpty()) { | |
259 | http.session.removeAttribute(sattr) | |
260 | } else { | |
261 | http.session.setAttribute(sattr, list.joinToString(",")) | |
262 | } | |
263 | } | |
264 | ||
265 | return http.session.getAttribute(sattr) | |
266 | ?.toString() | |
267 | ?.split(",") | |
268 | ?.map { enumValueOf(it) } | |
269 | ?: emptyList() | |
270 | } | |
271 | } |