From: Olaf Wintermann <olaf.wintermann@gmail.com>
Date: Tue, 19 May 2026 17:58:02 +0000 (+0200)
Subject: fix some warnings
X-Git-Url: https://uap-core.de/gitweb/?a=commitdiff_plain;h=refs%2Fheads%2Fmain;p=note.git

fix some warnings
---

diff --git a/ui-rs/src/ui/label.rs b/ui-rs/src/ui/label.rs
index 58212a6..9de206e 100644
--- a/ui-rs/src/ui/label.rs
+++ b/ui-rs/src/ui/label.rs
@@ -83,9 +83,7 @@ impl<'a, T> Drop for LabelBuilder<'a, T> {
 
 impl<'a, T> LabelBuilder<'a, T> {
     pub fn create(&mut self) -> Label {
-        unsafe {
-            Label { ptr: (self.create)(self.obj.ptr, self.args) }
-        }
+        Label { ptr: (self.create)(self.obj.ptr, self.args) }
     }
 
     pub fn fill(&mut self, fill: bool) -> &mut Self {
diff --git a/ui-rs/src/ui/menu.rs b/ui-rs/src/ui/menu.rs
index 0b867bc..9d84e23 100644
--- a/ui-rs/src/ui/menu.rs
+++ b/ui-rs/src/ui/menu.rs
@@ -160,7 +160,7 @@ impl<T: UiModel + UiActions> MenuItemBuilder<T> {
     pub fn onclick<F>(&mut self, f: F) -> &mut Self
     where F: FnMut(&mut event::Event<T>) + 'static {
         let wrapper = Box::new(EventWrapper { callback: Box::new(f) });
-        let mut ctx = UiContext { ptr: self.ctx };
+        let ctx = UiContext { ptr: self.ctx };
         let ptr = ctx.reg_box(wrapper);
         unsafe {
             ui_menuitem_args_set_onclick(self.args, Some(event::event_wrapper::<T>));
@@ -211,7 +211,7 @@ impl<T: UiModel + UiActions> MenuToggleItemBuilder<T> {
     pub fn onchange<F>(&mut self, f: F) -> &mut Self
     where F: FnMut(&mut event::Event<T>) + 'static {
         let wrapper = Box::new(EventWrapper { callback: Box::new(f) });
-        let mut ctx = UiContext { ptr: self.ctx };
+        let ctx = UiContext { ptr: self.ctx };
         let ptr = ctx.reg_box(wrapper);
         unsafe {
             ui_menutoggleitem_args_set_onchange(self.args, Some(event::event_wrapper::<T>));
diff --git a/ui-rs/src/ui/toolbar.rs b/ui-rs/src/ui/toolbar.rs
index 2f8fa35..defdbab 100644
--- a/ui-rs/src/ui/toolbar.rs
+++ b/ui-rs/src/ui/toolbar.rs
@@ -157,7 +157,7 @@ impl<T: UiModel + UiActions> ToolbarItemBuilder<T> {
     pub fn onclick<F>(&mut self, f: F) -> &mut Self
     where F: FnMut(&mut event::Event<T>) + 'static {
         let wrapper = Box::new(EventWrapper { callback: Box::new(f) });
-        let mut ctx = UiContext { ptr: self.ctx };
+        let ctx = UiContext { ptr: self.ctx };
         let ptr = ctx.reg_box(wrapper);
         unsafe {
             ui_toolbar_item_args_set_onclick(self.args, Some(event::event_wrapper::<T>));
@@ -224,7 +224,7 @@ impl<T: UiModel + UiActions> ToolbarToggleItemBuilder<T> {
     pub fn onchange<F>(&mut self, f: F) -> &mut Self
     where F: FnMut(&mut event::Event<T>) + 'static {
         let wrapper = Box::new(EventWrapper { callback: Box::new(f) });
-        let mut ctx = UiContext { ptr: self.ctx };
+        let ctx = UiContext { ptr: self.ctx };
         let ptr = ctx.reg_box(wrapper);
         unsafe {
             ui_toolbar_toggleitem_args_set_onchange(self.args, Some(event::event_wrapper::<T>));
diff --git a/ui-rs/src/ui/toolkit.rs b/ui-rs/src/ui/toolkit.rs
index 483e2a9..0fc6609 100644
--- a/ui-rs/src/ui/toolkit.rs
+++ b/ui-rs/src/ui/toolkit.rs
@@ -158,7 +158,7 @@ impl<T: UiModel + UiActions> UiDoc<T> {
     pub fn new(mut data: T) -> UiDoc<T> {
         unsafe {
             let doc = ui_document_new(mem::size_of::<*mut T>());
-            let mut ctx = UiContext { ptr: ui_document_context(doc) };
+            let ctx = UiContext { ptr: ui_document_context(doc) };
             data.init(&ctx);
             let data_ptr = ctx.reg_box(Box::new(data)); // returns *mut T
             let doc_storage: *mut *mut T = doc.cast();
@@ -307,7 +307,7 @@ impl<T> Drop for UiObjRef<T> {
 
             // only unregister if the object still exists
             if !obj_ptr.is_null() {
-                let ctx = unsafe { ui_object_get_context(obj_ptr) };
+                let ctx = ui_object_get_context(obj_ptr);
                 let xptr = &mut *self.ptr as *mut *mut ffi::UiObject;
                 ui_remove_destructor(ctx, xptr as *mut c_void);
             }